-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libjulia_jll: turn LibOSXUnwind_jll into a build dep for Julia 1.6 #4320
libjulia_jll: turn LibOSXUnwind_jll into a build dep for Julia 1.6 #4320
Conversation
875a0d5
to
038f59d
Compare
aed07a9
to
dc818c0
Compare
Thanks for working on this @giordano. I've renamed my patch to hopefully fix the |
Yeah, this is becoming a circular issue... |
:-(. next idea then: manually download and extract the libunwindOSX artifact, remove it as a builddep. But need sleep first |
18acfe4
to
2bf85c7
Compare
@giordano how can I fix this again?
|
|
sigh
|
Yeah, they all need to become |
2f8a484
to
6798411
Compare
This should be ready. But perhaps should be merged with skip ci, skip build, and then we focus on PR #4461. |
It was broken anyway, and not worth fixing at this point. On the up side, this simplifies the code quite a bit
6798411
to
969d845
Compare
Thanks a lot Max! |
…uliaPackaging#4320) * [libjulia] Make all versions proper `VersionNumber` * [libjulia] Fix git repository URL * [libjulia] turn LibOSXUnwind_jll into a build dep for Julia 1.6 * [libjulia] Drop support for building Julia <= 1.5 It was broken anyway, and not worth fixing at this point. On the up side, this simplifies the code quite a bit Co-authored-by: Mosè Giordano <mose@gnu.org> [skip ci]
This is experimental. I still need to verify that the result can
be used to build other JLLs using
libjulia_jll
. But I thoughtit'd be good to already collect feedback here.
[skip ci] [skip build]