[NetCDF] upgrade to NetCDF v4.8.1 for non-Windows platforms and julia 1.8 compat #4826
Conversation
…ia ≥ v1.6; Windows build is known to fail
|
@Seelengrab this is why backporting JuliaLang/julia#43250 would wreak havoc everywhere |
| @@ -0,0 +1,675 @@ | |||
| From fcf179c6c799020871eed3ecbcc4dd34a9663c3b Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
These are relatively large patches, touching lots of files. It'd be good to upstream all changes that are general and not specific to our build system, to reduce our maintenance burden.
There was a problem hiding this comment.
The large first patch is actually from upstream (@DennisHeimbigner) and merged in main but not jet available in a released version. This patch should no longer be necessary in upcoming releases.
For the two other patches, I filled these issues/PRs:
Unidata/netcdf-c#2303 (PR: Unidata/netcdf-c#2304)
Unidata/netcdf-c#2302 (PR: Unidata/netcdf-c#2305)
N/NetCDF/common.jl
Outdated
| # The following libraries are dependencies of LibCURL_jll which is now a | ||
| # stdlib, but the stdlib doesn't explicitly list its dependencies | ||
| Dependency("LibSSH2_jll", v"1.10.2"), | ||
| Dependency("MbedTLS_jll", v"2.28.0"), | ||
| Dependency("nghttp2_jll"), |
There was a problem hiding this comment.
The comment hasn't been true for quite some time (and it has been true for only few days). Did you try removing these lines?
There was a problem hiding this comment.
Indeed, the compilation works if I remove the indirect dependencies. The PR is updated.
Currently NetCDF_jll cannot be installed on any OS with julia 1.8 due to the fact that julia uses different versions of libcurl, LibSSH2, MbedTLS (than julia 1.6 and julia 1.7)
This PR:
0001-Fix-a-number-of-OS-specific-bugs.patchis from upstream, but not yet available in a released version).make checkon Linux (to hopefully catch issues earlier)Windows issue is also reported upstream:
Unidata/netcdf-c#2248
CC: @visr