Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XGBoost 0.82 #657

Merged
merged 5 commits into from
Mar 28, 2020
Merged

Update XGBoost 0.82 #657

merged 5 commits into from
Mar 28, 2020

Conversation

ViralBShah
Copy link
Member

No description provided.

@staticfloat
Copy link
Member

Try removing the part that copies libgomp over and instead expressing a dependency on CompilerSupportLibraries_jll.

@ViralBShah
Copy link
Member Author

Try removing the part that copies libgomp over and instead expressing a dependency on CompilerSupportLibraries_jll.

That was timely. Thanks!

@ViralBShah ViralBShah changed the title Try building xgboost 0.82 Update XGBoost 0.82 Mar 28, 2020
@ViralBShah ViralBShah merged commit 1a9daf8 into master Mar 28, 2020
@ViralBShah ViralBShah deleted the vs/xgboost0.82 branch March 28, 2020 00:59
@aviks
Copy link
Contributor

aviks commented Apr 4, 2020

So using this artifact, tests fail on Mac (but pass on Linux and Windows. Failure on Mac looks like this:

dyld: lazy symbol binding failed: Symbol not found: ___cxa_thread_atexit
  Referenced from: /Users/travis/.julia/artifacts/3ff38e086f3b040acfb66c0e7d42fac2bdc6eea5/lib/libxgboost.dylib
  Expected in: /Users/travis/.julia/artifacts/7c9ef733699a1d86b8a6073ed08a4457e3e790f7/lib/libstdc++.6.dylib

dyld: Symbol not found: ___cxa_thread_atexit
  Referenced from: /Users/travis/.julia/artifacts/3ff38e086f3b040acfb66c0e7d42fac2bdc6eea5/lib/libxgboost.dylib
  Expected in: /Users/travis/.julia/artifacts/7c9ef733699a1d86b8a6073ed08a4457e3e790f7/lib/libstdc++.6.dylib

signal (6): Abort trap: 6
in expression starting at /Users/travis/build/dmlc/XGBoost.jl/test/runtests.jl:8

signal (6): Abort trap: 6
in expression starting at /Users/travis/build/dmlc/XGBoost.jl/test/runtests.jl:8
unknown function (ip: 0x1098c5249)

Allocations: 10016393 (Pool: 10014671; Big: 1722); GC: 11

@giordano
Copy link
Member

giordano commented Apr 4, 2020

Better open an issue here in Yggdrasil, otherwise this comment will likely be lost

@ViralBShah
Copy link
Member Author

ViralBShah commented Apr 5, 2020

Note that the xgboost darwin build has a ton of warnings and scary looking messages. Any idea what can fix these? Perhaps that will also fix the issue.

https://dev.azure.com/JuliaPackaging/Yggdrasil/_build/results?buildId=2228&view=logs&j=0e6f23d3-bbc5-5a5c-1679-8a7f37dad18d&t=62f65e56-6499-50ca-7cf6-50d14fe18c3b&l=57457

┌ Warning: Could not probe /agent/_work/1/s/X/XGBoost/build/x86_64-apple-darwin14-cxx11/2uBCPWc1/destdir/lib/libgcc_s.1.dylib for an SONAME!
│   exception = (ObjectFile.MagicMismatch("Object file is not any of ObjectFile.ELF.ELFHandle, ObjectFile.MachO.MachOHandle, ObjectFile.COFF.COFFHandle! To force one object file format use readmeta(io, T)."), Union{Ptr{Nothing}, Base.InterpreterIP}[Ptr{Nothing} @0x00007f2c1136febb, Ptr{Nothing} @0x00007f2c113c3cc7, Ptr{Nothing} @0x00007f2c44d90a5a, Ptr{Nothing} @0x00007f2c199b81e8, Ptr{Nothing} @0x00007f2c113c219e, Ptr{Nothing} @0x00007f2c113c1cac, Ptr{Nothing} @0x00007f2c113c1d11, Ptr{Nothing} @0x00007f2c44d8fd22, Ptr{Nothing} @0x00007f2c1136a626, Ptr{Nothing} @0x00007f2c1136c192  …  Ptr{Nothing} @0x00007f2c44dceb89, Ptr{Nothing} @0x00007f2c37ab1c91, Ptr{Nothing} @0x00007f2c37abc29f, Ptr{Nothing} @0x00007f2c37477163, Ptr{Nothing} @0x00007f2c374772a5, Ptr{Nothing} @0x00007f2c44d8fd22, Ptr{Nothing} @0x0000000000401931, Ptr{Nothing} @0x0000000000401533, Ptr{Nothing} @0x00007f2c44b0909a, Ptr{Nothing} @0x00000000004015d4])
└ @ BinaryBuilder /depot/packages/BinaryBuilder/4fMlX/src/auditor/soname_matching.jl:9
[00:55:52] ERROR: Failed to run /opt/x86_64-apple-darwin14/bin/install_name_tool!

"https://github.com/dmlc/xgboost.git"=>
"3f83dcd50286d7c8d22e552942bd6572547c32b9",
"./bundled",
GitSource("https://github.com/dmlc/xgboost.git","bf3241368256ddd010d30d98ffc8a0a005f166e9"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ViralBShah where did you get this git-sha from? The previous value is the tagged 0.8.2 version of XGBoost, but I cant find bf3241 sha in https://github.com/dmlc/xgboost

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's in the release_0.82 branch: dmlc/xgboost@bf32413

@aviks aviks mentioned this pull request Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants