Define general broadcasting of DArrays #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Things are moving in Base once again so we should hold off with merging this until JuliaLang/julia#19787 is merged and this PR updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the broadcasting functionality is frustratingly slow but I think it works correctly which is a start. Hopefully, we'll be able to speed things up later. Although this code is pretty type unstable, I don't think the performance issues are in this PR but rather in base or
DistributedArraysin general. See also #119.I've dropped support for Julia 0.5. The broadcasting code in base doesn't have a stable API for new
AbstractArraysextensions so it would require a separate implementation to support 0.5 which is not worth it with 0.6 being released relative soon.