Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename setsizes! to Base.resize! #23

Merged
merged 1 commit into from
Nov 17, 2015
Merged

Conversation

stevengj
Copy link
Contributor

resize! is the standard name for this functionality in Julia. Also, the Vec and Mat setsizes! methods were inconsistent (the former put the global size first, then the local size as keywords, whereas the latter was the reverse); in both cases the resize! function is now Julian in that it takes the global sizes as the first (albeit optional) arguments, and the local sizes as keywords.

@codecov-io
Copy link

Current coverage is 6.96%

Merging #23 into master will increase coverage by +0.03% as of aae53bd

@@            master    #23   diff @@
=====================================
  Files           17     17       
  Stmts         9698   9704     +6
  Branches         0      0       
  Methods          0      0       
=====================================
+ Hit            673    676     +3
  Partial          0      0       
- Missed        9025   9028     +3

Review entire Coverage Diff as of aae53bd

Powered by Codecov. Updated on successful CI builds.

stevengj added a commit that referenced this pull request Nov 17, 2015
rename setsizes! to Base.resize!
@stevengj stevengj merged commit 4a60f5e into JuliaParallel:master Nov 17, 2015
@stevengj stevengj deleted the resize branch November 17, 2015 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants