Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename /profile* to /cpu_profile* #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Nov 14, 2024

Likely a breaking change, but I believe we need this now that we have the wall-time profiler in order to make the distinction between CPU/Wall-time profiles clear.

@d-netto d-netto requested review from NHDaly and Drvi November 14, 2024 14:35
@NHDaly
Copy link
Member

NHDaly commented Nov 18, 2024

The conclusion is to wait on this, and do it in a staged deprecation + breaking change release process, in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants