Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MeasurementsJunoExt.jl #159

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

longemen3000
Copy link
Contributor

there was an extra line of Juno.Row
that line was introduced in #14.

this is one option, the other would be to define Juno.Row(measure::Measurement), but Juno.Row seems undocumented?

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #159 (0fcccb8) into master (3cf88eb) will not change coverage.
The diff coverage is n/a.

❗ Current head 0fcccb8 differs from pull request most recent head 9caf2e0. Consider uploading reports for the commit 9caf2e0 to get more accurate results

@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   96.60%   96.60%           
=======================================
  Files           9        9           
  Lines         619      619           
=======================================
  Hits          598      598           
  Misses         21       21           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@giordano
Copy link
Member

This whole Juno extension is completely broken, as far as I know, I'd be tempted by removing it at some point.

@giordano giordano merged commit ad9f0fc into JuliaPhysics:master Oct 31, 2023
11 checks passed
@giordano giordano linked an issue Oct 31, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken MeasurementsJunoExt.jl
2 participants