-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tickmarks the same length for both axes in GR 2D plots #3659
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3659 +/- ##
==========================================
+ Coverage 63.83% 63.91% +0.08%
==========================================
Files 28 28
Lines 6923 6925 +2
==========================================
+ Hits 4419 4426 +7
+ Misses 2504 2499 -5
Continue to review full report at Codecov.
|
Thats definetly an improvement, I would argue that the ticklength should be the same irrespective of the size of the window. |
Oh my god, this been bothering me since forever. I could never get it fixed myself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good to me
I actually think it should be like
where ticksize_y_axis is the old way of calculating it. So it would scale as before |
I think it looks a little to long compared to pyplot, maybe scale down by factor of 1.25 or 1.5? |
Overall, whatever you decide i support it. This is already much better than before |
This looks perfect to me. |
Avoid too short ticks for one axis in very wide or narrow plots. This changes
from
to
and
from
to