Use a stable RNG in fakedata #3661

t-bltg · 2021-07-22T09:50:57Z

Failures have been seen on nightly, change to a more stable random number generator.

@BeastyBlacksmith, if this is OK for you I will re-generate ref images.

BeastyBlacksmith · 2021-07-22T09:58:16Z

You'd need to move StableRNG from [extras] to [deps] in Project.toml, no?

t-bltg · 2021-07-22T09:59:36Z

You'd need to move StableRNG from [extras] to [deps] in Project.toml, no?

Yes, done.

BeastyBlacksmith · 2021-07-22T10:00:21Z

Thogh, I'd prefer that this stays a testdependency and you only allow passing a rng to fakedate and then pass the stable rng in the tests

t-bltg · 2021-07-22T10:03:41Z

Thogh, I'd prefer that this stays a testdependency and you only allow passing a rng to fakedate and then pass the stable rng in the tests

IMO, Plots.fakedata() is exposed to the user throughout src/examples.jl, so moving StableRNGs from extras to deps is justified. And also Plots.fakedata() resides in src/utils.jl, not in test/.

t-bltg · 2021-07-22T11:08:35Z

@BeastyBlacksmith all the test run with JuliaPlots/PlotReferenceImages.jl#106.
~~I've also replaced download (deprecated) with Downloads.download.~~

src/utils.jl

Co-authored-by: Simon Christ <SimonChrist@gmx.de>

t-bltg · 2021-07-23T09:11:58Z

Should we then hack again examples in replace_rand! to insert a keyword argument or should we modify the examples using Plots.fakedata ?

BeastyBlacksmith · 2021-07-23T09:58:24Z

I'd shadow it in the tests like fakedata(args...) = Plots.fakedata(args...; rng=StableRNG(Plots.PLOTS_SEED))

t-bltg · 2021-07-23T09:59:47Z

I'd shadow it in the tests like fakedata(args...) = Plots.fakedata(args...; rng=StableRNG(Plots.PLOTS_SEED))

Yeah that's more or less what I came up with.

Project.toml

src/Plots.jl

test/imgcomp.jl

BeastyBlacksmith

Still needs new reference figures

t-bltg · 2021-07-23T12:24:43Z

Still needs new reference figures

Yes, there are already here: JuliaPlots/PlotReferenceImages.jl#106. I will merge them now, if you're ok with that.

Update ref images for JuliaPlots/Plots.jl/pull/3661

codecov · 2021-07-23T12:46:13Z

Codecov Report

Merging #3661 (4e72c86) into master (a39582c) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 4e72c86 differs from pull request most recent head f3aa612. Consider uploading reports for the commit f3aa612 to get more accurate results

@@            Coverage Diff             @@
##           master    #3661      +/-   ##
==========================================
- Coverage   63.88%   63.80%   -0.09%     
==========================================
  Files          28       28              
  Lines        6923     6924       +1     
==========================================
- Hits         4423     4418       -5     
- Misses       2500     2506       +6

Impacted Files	Coverage Δ
src/Plots.jl	`31.42% <ø> (ø)`
src/examples.jl	`61.76% <ø> (ø)`
src/utils.jl	`52.62% <100.00%> (+0.08%)`	⬆️
src/recipes.jl	`57.64% <0.00%> (-0.46%)`	⬇️
src/axes.jl	`84.75% <0.00%> (-0.45%)`	⬇️
src/layouts.jl	`68.22% <0.00%> (-0.27%)`	⬇️
src/colorbars.jl	`92.15% <0.00%> (+1.96%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a39582c...f3aa612. Read the comment docs.

t-bltg · 2021-07-23T14:21:19Z

Failures are related to GraphRecipes, made a PR there: JuliaPlots/GraphRecipes.jl#162.

t-bltg force-pushed the rng branch from 4826300 to 5fdd7af Compare July 22, 2021 09:52

t-bltg force-pushed the rng branch from 5fdd7af to f7f9c1c Compare July 22, 2021 09:59

t-bltg force-pushed the rng branch from f7f9c1c to 5de2815 Compare July 22, 2021 10:05

t-bltg marked this pull request as draft July 22, 2021 10:06

t-bltg force-pushed the rng branch 4 times, most recently from be1a29f to fc4060f Compare July 22, 2021 10:28

t-bltg added a commit to t-bltg/PlotReferenceImages.jl that referenced this pull request Jul 22, 2021

update ref images for JuliaPlots/Plots.jl/pull/3661

ec47536

t-bltg added a commit to t-bltg/PlotReferenceImages.jl that referenced this pull request Jul 22, 2021

update ref images for JuliaPlots/Plots.jl/pull/3661

1b041fc

t-bltg marked this pull request as ready for review July 22, 2021 10:32

t-bltg force-pushed the rng branch 2 times, most recently from 515f704 to bd94832 Compare July 22, 2021 10:52

use a stable RNG in fakedata

fe7d957

t-bltg force-pushed the rng branch from bd94832 to fe7d957 Compare July 22, 2021 11:00

t-bltg requested a review from BeastyBlacksmith July 22, 2021 11:08

t-bltg mentioned this pull request Jul 22, 2021

More strict on tolerance - drop tol for obsolete version #3663

Closed

BeastyBlacksmith reviewed Jul 22, 2021

View reviewed changes

src/utils.jl Outdated Show resolved Hide resolved

Switch to Random.GLOBAL_RNG

cd06648

Co-authored-by: Simon Christ <SimonChrist@gmx.de>

t-bltg force-pushed the rng branch 3 times, most recently from 40ef655 to cc1a328 Compare July 23, 2021 09:47

t-bltg requested a review from BeastyBlacksmith July 23, 2021 10:20

BeastyBlacksmith reviewed Jul 23, 2021

View reviewed changes

Project.toml Outdated Show resolved Hide resolved

src/Plots.jl Outdated Show resolved Hide resolved

test/imgcomp.jl Outdated Show resolved Hide resolved

t-bltg force-pushed the rng branch 3 times, most recently from 8411c22 to 90e3fc0 Compare July 23, 2021 12:10

t-bltg requested a review from BeastyBlacksmith July 23, 2021 12:17

BeastyBlacksmith approved these changes Jul 23, 2021

View reviewed changes

t-bltg added a commit to JuliaPlots/PlotReferenceImages.jl that referenced this pull request Jul 23, 2021

Merge pull request #106 from t-bltg/rng2

dfa9dbd

Update ref images for JuliaPlots/Plots.jl/pull/3661

change fakedata rng in tests

f3aa612

t-bltg force-pushed the rng branch from 90e3fc0 to f3aa612 Compare July 23, 2021 12:47

t-bltg mentioned this pull request Jul 23, 2021

Use StableRNGs JuliaPlots/GraphRecipes.jl#162

Merged

t-bltg merged commit 878e590 into JuliaPlots:master Jul 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use a stable RNG in fakedata #3661

Use a stable RNG in fakedata #3661

t-bltg commented Jul 22, 2021 •

edited

Loading

BeastyBlacksmith commented Jul 22, 2021 •

edited

Loading

t-bltg commented Jul 22, 2021

BeastyBlacksmith commented Jul 22, 2021

t-bltg commented Jul 22, 2021 •

edited

Loading

t-bltg commented Jul 22, 2021

t-bltg commented Jul 23, 2021

BeastyBlacksmith commented Jul 23, 2021

t-bltg commented Jul 23, 2021 •

edited

Loading

BeastyBlacksmith left a comment

t-bltg commented Jul 23, 2021 •

edited

Loading

codecov bot commented Jul 23, 2021 •

edited

Loading

t-bltg commented Jul 23, 2021 •

edited

Loading

Use a stable RNG in fakedata #3661

Use a stable RNG in fakedata #3661

Conversation

t-bltg commented Jul 22, 2021 • edited Loading

BeastyBlacksmith commented Jul 22, 2021 • edited Loading

t-bltg commented Jul 22, 2021

BeastyBlacksmith commented Jul 22, 2021

t-bltg commented Jul 22, 2021 • edited Loading

t-bltg commented Jul 22, 2021

t-bltg commented Jul 23, 2021

BeastyBlacksmith commented Jul 23, 2021

t-bltg commented Jul 23, 2021 • edited Loading

BeastyBlacksmith left a comment

Choose a reason for hiding this comment

t-bltg commented Jul 23, 2021 • edited Loading

codecov bot commented Jul 23, 2021 • edited Loading

Codecov Report

t-bltg commented Jul 23, 2021 • edited Loading

t-bltg commented Jul 22, 2021 •

edited

Loading

BeastyBlacksmith commented Jul 22, 2021 •

edited

Loading

t-bltg commented Jul 22, 2021 •

edited

Loading

t-bltg commented Jul 23, 2021 •

edited

Loading

t-bltg commented Jul 23, 2021 •

edited

Loading

codecov bot commented Jul 23, 2021 •

edited

Loading

t-bltg commented Jul 23, 2021 •

edited

Loading