Update Plots.jl's colorbar_titel maps to PGFPlotsX's color bar style={ylabel}
#3848
Conversation
For most of the backends supported by Polts.jl the `colorbar_title` attribute maps to the attribute in the backend that ultimately is displayed on the vertical axis of the colorbar, which is vertically aligned. Not for PGFPlotsX as in this backend the `title` attribute is displayed on top of the colorbar while the `ylabel` is shown on the vertical bar.
Codecov Report
@@ Coverage Diff @@
## master #3848 +/- ##
==========================================
+ Coverage 63.22% 63.23% +0.01%
==========================================
Files 28 28
Lines 7491 7491
==========================================
+ Hits 4736 4737 +1
+ Misses 2755 2754 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
That looks reasonable to me, since this is your first contribution can you take a look at #3503 and if you like to, add your information to our .zenodo.json file?
added my name to the contributors list
|
Hello @BeastyBlacksmith ! |
For most of the backends supported by Plots.jl the
colorbar_titleattribute maps to the attribute in the backend that ultimately is displayed on the vertical axis of the colorbar, which is vertically aligned as well.However, this is not the case for PGFPlotsX as in this backend the
titleattribute is displayed on top of the colorbar while theylabelis shown on the vertical bar.This PR proposes this change for consistency and, admittedly very subjective, better looks.
Let me know if this is appreciated and/or desired.
Cheers
Jan