Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework warn_on_unsupported #4081

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Jan 28, 2022

I need this to go in for extra_kwargs to work properly in UnicodePlots.
warn_on_unsupported should be evaluated per backend.

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #4081 (6db248d) into master (824dbe9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4081      +/-   ##
==========================================
- Coverage   62.22%   62.22%   -0.01%     
==========================================
  Files          29       29              
  Lines        7293     7295       +2     
==========================================
+ Hits         4538     4539       +1     
- Misses       2755     2756       +1     
Impacted Files Coverage Δ
src/args.jl 72.45% <100.00%> (-0.12%) ⬇️
src/backends/unicodeplots.jl 53.37% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 824dbe9...6db248d. Read the comment docs.

@BeastyBlacksmith
Copy link
Member

Why is that needed? Extra keyword arguments shouldn't be treated as unsupportet arguments. Or do you have keywords that conflict with Plots default keywords?

@t-bltg
Copy link
Member Author

t-bltg commented Jan 28, 2022

Because

warn_on_unsupported_args(::UnicodePlotsBackend, plotattributes) = nothing
was a cheap way to remove unsupported arguments warnings, and basically disabled extra_kwargs by returning nothing.

@BeastyBlacksmith
Copy link
Member

Can't we remove that line then?

@t-bltg
Copy link
Member Author

t-bltg commented Jan 28, 2022

Can't we remove that line then?

I already dit it in 3e8db45, replaced it with plt.attr[:warn_on_unsupported] = false, but that doesn't work (too late in the pipeline, and I didn't catch that because of the Revise workflow), and thus tons of warnings are appearing again.

Copy link
Member

@BeastyBlacksmith BeastyBlacksmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, makes sense

@t-bltg t-bltg merged commit 2896c5a into JuliaPlots:master Jan 28, 2022
@t-bltg t-bltg deleted the warn_unsupported branch January 28, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants