-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework warn_on_unsupported #4081
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4081 +/- ##
==========================================
- Coverage 62.22% 62.22% -0.01%
==========================================
Files 29 29
Lines 7293 7295 +2
==========================================
+ Hits 4538 4539 +1
- Misses 2755 2756 +1
Continue to review full report at Codecov.
|
Why is that needed? Extra keyword arguments shouldn't be treated as unsupportet arguments. Or do you have keywords that conflict with Plots default keywords? |
Because Plots.jl/src/backends/unicodeplots.jl Line 4 in 5facd2b
extra_kwargs by returning nothing .
|
Can't we remove that line then? |
I already dit it in 3e8db45, replaced it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, makes sense
I need this to go in for
extra_kwargs
to work properly inUnicodePlots
.warn_on_unsupported
should be evaluated per backend.