Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort supported args #4156

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Conversation

IanButterworth
Copy link
Contributor

Adds sorting to this tip because the unsorted options are hard to scan.

Screenshot from 2022-03-27 20-02-44

src/args.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #4156 (82ecb57) into master (0f4a0c7) will not change coverage.
The diff coverage is n/a.

❗ Current head 82ecb57 differs from pull request most recent head 8c9283f. Consider uploading reports for the commit 8c9283f to get more accurate results

@@           Coverage Diff           @@
##           master    #4156   +/-   ##
=======================================
  Coverage   77.46%   77.46%           
=======================================
  Files          28       28           
  Lines        7048     7048           
=======================================
  Hits         5460     5460           
  Misses       1588     1588           
Impacted Files Coverage Δ
src/args.jl 74.24% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4a0c7...8c9283f. Read the comment docs.

@BeastyBlacksmith
Copy link
Member

I think supported_attrs could already return the sorted vector

@BeastyBlacksmith BeastyBlacksmith merged commit eb746d1 into JuliaPlots:master Mar 29, 2022
@IanButterworth IanButterworth deleted the patch-1 branch March 29, 2022 16:15
@t-bltg
Copy link
Member

t-bltg commented Mar 29, 2022

Why merge something which doesn't pass ci ?

@BeastyBlacksmith
Copy link
Member

Hmm.. I thought I was fighting the same issue as in the other PRs. Anyway, it's fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants