Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored plotly hover functionality for plots with multidimensional data #4159

Merged
merged 4 commits into from
Mar 29, 2022
Merged

Restored plotly hover functionality for plots with multidimensional data #4159

merged 4 commits into from
Mar 29, 2022

Conversation

stevenaleung
Copy link
Contributor

@stevenaleung stevenaleung commented Mar 29, 2022

By default, the :hover keyword is initialized to nothing. Therefore, the if statement in plotly_hover!() defaults to true and the :hoverinfo keyword is set to none, which turns off the data label

Splitting the if statement expression into two restores the default data label functionality and preserves the functionality to turn off the data label

Functionality is restored for heatmap, contour, wireframe, and mesh3d

Resolves #2446, resolves #3051

src/backends/plotly.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #4159 (2c54cf9) into master (0f4a0c7) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4159      +/-   ##
==========================================
+ Coverage   77.46%   77.51%   +0.04%     
==========================================
  Files          28       28              
  Lines        7048     7048              
==========================================
+ Hits         5460     5463       +3     
+ Misses       1588     1585       -3     
Impacted Files Coverage Δ
src/recipes.jl 63.56% <0.00%> (+0.22%) ⬆️
src/axes.jl 85.71% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4a0c7...2c54cf9. Read the comment docs.

Co-authored-by: t-bltg <tf.bltg@gmail.com>
@BeastyBlacksmith BeastyBlacksmith merged commit a33c020 into JuliaPlots:master Mar 29, 2022
@stevenaleung stevenaleung deleted the fix_plotly_heatmap_hover branch April 1, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Heatmap without mouse hovering Plotly: heatmaps data on hover has disappeared
3 participants