Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the colorbar title for colorbars on the top. #4191

Merged

Conversation

zhiyuanzhai
Copy link
Contributor

Related: #4183.

For the following test code:

using Plots
pgfplotsx()
plot(rand(10, 2), marker_z=rand(10), seriestype=:scatter, cb=:top, cb_title="mark")

before this fix:
截屏2022-05-02 11 31 19
while after this fix:
mark

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #4191 (217f629) into master (0622042) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #4191      +/-   ##
==========================================
- Coverage   77.83%   77.82%   -0.02%     
==========================================
  Files          28       28              
  Lines        7056     7057       +1     
==========================================
  Hits         5492     5492              
- Misses       1564     1565       +1     
Impacted Files Coverage Δ
src/backends/pgfplotsx.jl 71.13% <50.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0622042...217f629. Read the comment docs.

@BeastyBlacksmith
Copy link
Member

Thanks!

@BeastyBlacksmith BeastyBlacksmith merged commit 137d339 into JuliaPlots:master May 2, 2022
@zhiyuanzhai zhiyuanzhai deleted the fixing_cbtitle_for_top_cb branch May 2, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants