Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update UnicodePlots to 3.0.0 - coverage #4250

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Jun 24, 2022

  • eval ref imgs in a specific module (avoids leaking);
  • rename test files, clarify test structure;
  • update compat entries;
  • lots of simplifications;
  • improve coverage.

@t-bltg t-bltg added the CI continuous integration label Jun 24, 2022
@t-bltg t-bltg force-pushed the upd branch 2 times, most recently from 032cf41 to 6cd4a61 Compare June 24, 2022 10:37
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #4250 (75c0682) into master (03d015c) will increase coverage by 1.05%.
The diff coverage is 63.35%.

@@            Coverage Diff             @@
##           master    #4250      +/-   ##
==========================================
+ Coverage   77.87%   78.93%   +1.05%     
==========================================
  Files          28       29       +1     
  Lines        7111     7041      -70     
==========================================
+ Hits         5538     5558      +20     
+ Misses       1573     1483      -90     
Impacted Files Coverage Δ
src/backends/unicodeplots.jl 85.48% <0.00%> (+0.90%) ⬆️
src/components.jl 88.06% <0.00%> (+0.24%) ⬆️
src/utils.jl 63.94% <0.00%> (+1.72%) ⬆️
src/animation.jl 78.88% <33.33%> (+0.39%) ⬆️
src/plotmeasures.jl 40.00% <40.00%> (ø)
src/colorbars.jl 87.69% <50.00%> (+1.12%) ⬆️
src/recipes.jl 66.33% <50.00%> (+1.97%) ⬆️
src/axes.jl 85.77% <66.66%> (+0.34%) ⬆️
src/output.jl 62.92% <66.66%> (+0.06%) ⬆️
src/backends/pgfplotsx.jl 70.86% <67.74%> (-0.08%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d015c...75c0682. Read the comment docs.

@t-bltg t-bltg merged commit a4d8ccf into JuliaPlots:master Jun 24, 2022
@t-bltg t-bltg deleted the upd branch June 24, 2022 16:35
@t-bltg t-bltg mentioned this pull request Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration UnicodePlots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant