Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump GR version #4384

Merged
merged 2 commits into from
Sep 27, 2022
Merged

bump GR version #4384

merged 2 commits into from
Sep 27, 2022

Conversation

jheinen
Copy link
Member

@jheinen jheinen commented Sep 27, 2022

Bump GR version to 0.69.1

Bump GR version to 0.69.1
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 80.82% // Head: 80.82% // No change to project coverage 👍

Coverage data is based on head (ba26cb1) compared to base (1c86ab5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4384   +/-   ##
=======================================
  Coverage   80.82%   80.82%           
=======================================
  Files          30       30           
  Lines        7449     7449           
=======================================
  Hits         6021     6021           
  Misses       1428     1428           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@t-bltg
Copy link
Member

t-bltg commented Sep 27, 2022

Don't bother about the benchmarks.

1.6 ubuntu is stale, I'm going to cancel it and restart.

@t-bltg
Copy link
Member

t-bltg commented Sep 27, 2022

I'm trying to fix the conda related issues in #4386, before we re-run ci here.

@t-bltg
Copy link
Member

t-bltg commented Sep 27, 2022

CI is green (again).

@jheinen
Copy link
Member Author

jheinen commented Sep 27, 2022

CI is green (again).

Should we merge?

@t-bltg
Copy link
Member

t-bltg commented Sep 27, 2022

Should we merge?

Certainly go ahead, the question is should we release a new Plots version ?

@jheinen
Copy link
Member Author

jheinen commented Sep 27, 2022

Certainly go ahead, the question is should we release a new Plots version ?

I'd like to merge and then make some tests with Plots#master. If everything is fine, we should release a new Plots version.

But I'm confident.

@jheinen jheinen merged commit abd02af into JuliaPlots:master Sep 27, 2022
@jheinen
Copy link
Member Author

jheinen commented Sep 27, 2022

LGTM - even on Windows 😲

@jheinen
Copy link
Member Author

jheinen commented Sep 27, 2022

I'm now on Plots#master and GR 0.69.1 - everything looks fine. IMO, you can tag a new version.

@t-bltg
Copy link
Member

t-bltg commented Sep 27, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants