-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Title location and alignment #4410
Conversation
Codecov ReportBase: 80.87% // Head: 80.80% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4410 +/- ##
==========================================
- Coverage 80.87% 80.80% -0.07%
==========================================
Files 30 30
Lines 7439 7445 +6
==========================================
Hits 6016 6016
- Misses 1423 1429 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Using helper function for GR alignment specifiers Co-authored-by: t-bltg <tf.bltg@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is difficult to test this without ref images (since it is backend dependent), and I don't think adding some is necessary, so LGTM.
Problems:
This is already an improvement over the current state: it is left for another PR.
Adds manual plot title positioning with a tuple (x,y) (as was done in PGFPlotsX) for GR and Plotly.
Also adds title font alignment for GR, Plotly and PGFPlotsX since it also impacts title position.
Problems:
Partially fixes #4407 (since only GR and Plotly are fixed).