Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default theme by default #4420

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Conversation

gustaphe
Copy link
Collaborator

@gustaphe gustaphe commented Oct 4, 2022

Solves #4398

I'm not entirely sure why #4398 happens, I can't track down any of the awkward settings to any setting in Plots, PlotsThemes or anywhere else I could think of. But if you supply a theme it doesn't happen, and giving :default if no other theme is supplied should be pretty uncontroversial.

Copy link
Member

@t-bltg t-bltg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI.

@t-bltg t-bltg added the bug label Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 80.78% // Head: 80.40% // Decreases project coverage by -0.37% ⚠️

Coverage data is based on head (18310fb) compared to base (2823d49).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4420      +/-   ##
==========================================
- Coverage   80.78%   80.40%   -0.38%     
==========================================
  Files          30       30              
  Lines        7448     7171     -277     
==========================================
- Hits         6017     5766     -251     
+ Misses       1431     1405      -26     
Impacted Files Coverage Δ
src/init.jl 100.00% <100.00%> (ø)
src/consts.jl 66.66% <0.00%> (-8.34%) ⬇️
src/axes.jl 84.06% <0.00%> (-2.07%) ⬇️
src/backends/unicodeplots.jl 86.52% <0.00%> (-1.04%) ⬇️
src/backends/pgfplotsx.jl 75.45% <0.00%> (-0.82%) ⬇️
src/backends/hdf5.jl 82.30% <0.00%> (-0.72%) ⬇️
src/backends/gr.jl 88.27% <0.00%> (-0.61%) ⬇️
src/backends/gaston.jl 82.00% <0.00%> (-0.58%) ⬇️
src/examples.jl 91.04% <0.00%> (-0.39%) ⬇️
src/pipeline.jl 95.90% <0.00%> (-0.23%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gustaphe
Copy link
Collaborator Author

gustaphe commented Oct 4, 2022

I'm taking the liberty of ignoring codecov - this simply lowers coverage by decreasing the number of loc.

@gustaphe gustaphe merged commit 43b0111 into JuliaPlots:master Oct 4, 2022
@gustaphe gustaphe deleted the plots_defaults branch October 4, 2022 09:51
@t-bltg
Copy link
Member

t-bltg commented Oct 4, 2022

I'm taking the liberty of ignoring codecov

We all do that ;)

@gustaphe
Copy link
Collaborator Author

gustaphe commented Oct 4, 2022

Okay, there's a double commit now. Next time I'll get it right ...

@t-bltg
Copy link
Member

t-bltg commented Oct 4, 2022

Regarding the Plots versions increment, we usually wait a few days (typically a week) between patches unless something urgent (precompilation, dependencies, affecting lots of users) requires it, and avoid flooding the registry with new versions for a single Plots commit.

There was a lot of versions in 1.34.x in a small time window because of nasty GR issues induced by the transition from GR@0.68 to GR@0.69 were affecting lots of user on windows and macOS.

I've tagged 1.35.1 today, because GR@0.69.3 would potentially fix #4415, and this affects potentially hundreds if not thousands of macOS users.

So 1.35.2 could have waited a few days I guess (and IMO !) ...
Just a word on common practices here, nothing serious ;)

Cc @BeastyBlacksmith.

@gustaphe
Copy link
Collaborator Author

gustaphe commented Oct 4, 2022

Mea culpa, I'll be less trigger happy in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants