-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default theme by default #4420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending CI.
Codecov ReportBase: 80.78% // Head: 80.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4420 +/- ##
==========================================
- Coverage 80.78% 80.40% -0.38%
==========================================
Files 30 30
Lines 7448 7171 -277
==========================================
- Hits 6017 5766 -251
+ Misses 1431 1405 -26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I'm taking the liberty of ignoring codecov - this simply lowers coverage by decreasing the number of loc. |
We all do that ;) |
Okay, there's a double commit now. Next time I'll get it right ... |
Regarding the There was a lot of versions in I've tagged So |
Mea culpa, I'll be less trigger happy in the future. |
Solves #4398
I'm not entirely sure why #4398 happens, I can't track down any of the awkward settings to any setting in Plots, PlotsThemes or anywhere else I could think of. But if you supply a theme it doesn't happen, and giving
:default
if no other theme is supplied should be pretty uncontroversial.