Singleargustrip

[gustaphe]

Description

There was a bug hiding behind a test that didn't actually render the part that was supposed to be tested. Annotations with unitful coordinates used a non-working version of _ustrip. This fixes that.

Attribution

• I am listed in .zenodo.json (see How to get acknowledged #3503)

[gustaphe]

I can't fix the visual regressions because my system never shows a confirmation box, and I would be really surprised if they are caused by this PR.

[BeastyBlacksmith]

I can reproduce the failures on master as well

[gustaphe]

By the way, I can't run the test suite with the ENV setting either, because i get a segfault partway through. It might just be my computer being bad, or something about my python install. If there's no visual regression I've just used CI for tests in the past, but that doesn't work when I need to update the references.

(Perhaps a dream could be to get visual regression prompts as a comment on the PR, that would also automatically let the community see what your change does if it's visual)

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (552328c) 90.33% compared to head (8fa1dea) 90.33%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4752   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files          40       40           
  Lines        8739     8739           
=======================================
  Hits         7894     7894           
  Misses        845      845           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.