-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix heatmap with logarithmic colorbar #4770
Conversation
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
julia> x = y = collect(-10:0.01f0:10);
julia> heatmap(x, y, hypot.(x', y) .+ 1; colorbar_scale=:log10) # => it works
julia> heatmap(x, y, hypot.(x', y); colorbar_scale=:log10) # => clear error message
julia> x = y = collect(-10:0.01:10);
julia> heatmap(x, y, hypot.(x', y) .+ 1; colorbar_scale=:log10) # => it works
julia> heatmap(x, y, hypot.(x', y); colorbar_scale=:log10) # => clear error message Now the two eltypes are consistent and one gets clear error messages when the color range would be non-finite, instead of getting a confusing blank plot. Thanks! 🚀 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4770 +/- ##
==========================================
- Coverage 90.31% 90.29% -0.03%
==========================================
Files 40 40
Lines 8744 8746 +2
==========================================
Hits 7897 7897
- Misses 847 849 +2
☔ View full report in Codecov by Sentry. |
Description
Fix #4769
Attribution