Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix heatmap with logarithmic colorbar #4770

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Conversation

BeastyBlacksmith
Copy link
Member

Description

Fix #4769

Attribution

@BeastyBlacksmith BeastyBlacksmith changed the title fix assignment, throw errow on non-finite limits fix heatmap with logarithmic colorbar Jun 9, 2023
src/backends/gr.jl Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

  • Time of benchmarks:
    • Target: 9 Jun 2023 - 13:36
    • Baseline: 9 Jun 2023 - 13:37
  • Package commits:
    • Target: a2aa68
    • Baseline: 202328
  • Julia commits:
    • Target: 147bdf
    • Baseline: 147bdf
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["display"] 0.01 (5%) ✅ 0.01 (1%) ✅
["plot"] 0.83 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Target

Julia Version 1.9.1
Commit 147bdf428cd (2023-06-07 08:27 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.2 LTS
  uname: Linux 5.15.0-1038-azure #45-Ubuntu SMP Mon Apr 24 15:40:42 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       2425 s          0 s        215 s       2671 s          0 s
       #2  2793 MHz       2026 s          0 s        227 s       3052 s          0 s
  Memory: 6.7812042236328125 GB (5232.9375 MB free)
  Uptime: 537.47 sec
  Load Avg:  1.05  1.06  0.58
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.9.1
Commit 147bdf428cd (2023-06-07 08:27 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.2 LTS
  uname: Linux 5.15.0-1038-azure #45-Ubuntu SMP Mon Apr 24 15:40:42 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       3442 s          0 s        231 s       2801 s          0 s
       #2  2793 MHz       2151 s          0 s        238 s       4076 s          0 s
  Memory: 6.7812042236328125 GB (5207.15625 MB free)
  Uptime: 653.82 sec
  Load Avg:  1.09  1.07  0.64
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Target result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

  • Time of benchmark: 9 Jun 2023 - 13:36
  • Package commit: a2aa68
  • Julia commit: 147bdf
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["display"] 2.939 ms (5%) 360.50 KiB (1%) 6973
["load"] 2.753 s (5%) 4.59 KiB (1%) 92
["load_plot_display"] 3.277 s (5%) 4.62 KiB (1%) 92
["plot"] 563.193 μs (5%) 86.44 KiB (1%) 3123

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.9.1
Commit 147bdf428cd (2023-06-07 08:27 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.2 LTS
  uname: Linux 5.15.0-1038-azure #45-Ubuntu SMP Mon Apr 24 15:40:42 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       2425 s          0 s        215 s       2671 s          0 s
       #2  2793 MHz       2026 s          0 s        227 s       3052 s          0 s
  Memory: 6.7812042236328125 GB (5232.9375 MB free)
  Uptime: 537.47 sec
  Load Avg:  1.05  1.06  0.58
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Baseline result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

  • Time of benchmark: 9 Jun 2023 - 13:37
  • Package commit: 202328
  • Julia commit: 147bdf
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["display"] 520.904 ms (5%) 32.87 MiB (1%) 559627
["load"] 2.764 s (5%) 4.59 KiB (1%) 92
["load_plot_display"] 3.386 s (5%) 4.62 KiB (1%) 92
["plot"] 676.095 μs (5%) 86.44 KiB (1%) 3123

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.9.1
Commit 147bdf428cd (2023-06-07 08:27 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.2 LTS
  uname: Linux 5.15.0-1038-azure #45-Ubuntu SMP Mon Apr 24 15:40:42 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       3442 s          0 s        231 s       2801 s          0 s
       #2  2793 MHz       2151 s          0 s        238 s       4076 s          0 s
  Memory: 6.7812042236328125 GB (5207.15625 MB free)
  Uptime: 653.82 sec
  Load Avg:  1.09  1.07  0.64
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Runtime information

Runtime Info
BLAS #threads 1
BLAS.vendor() lbt
Sys.CPU_THREADS 2

lscpu output:

Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Address sizes:                   46 bits physical, 48 bits virtual
Byte Order:                      Little Endian
CPU(s):                          2
On-line CPU(s) list:             0,1
Vendor ID:                       GenuineIntel
Model name:                      Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
CPU family:                      6
Model:                           106
Thread(s) per core:              1
Core(s) per socket:              2
Socket(s):                       1
Stepping:                        6
BogoMIPS:                        5586.87
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear
Hypervisor vendor:               Microsoft
Virtualization type:             full
L1d cache:                       96 KiB (2 instances)
L1i cache:                       64 KiB (2 instances)
L2 cache:                        2.5 MiB (2 instances)
L3 cache:                        48 MiB (1 instance)
NUMA node(s):                    1
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     KVM: Mitigation: VMX unsupported
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Mmio stale data:   Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed:          Not affected
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Mitigation; Clear CPU buffers; SMT Host state unknown
Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
Vendor :Intel
Architecture :UnknownIntel
Model Family: 0x06, Model: 0x6a, Stepping: 0x06, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (48, 1280, 49152) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

  • Time of benchmarks:
    • Target: 9 Jun 2023 - 14:01
    • Baseline: 9 Jun 2023 - 14:04
  • Package commits:
    • Target: add9b8
    • Baseline: 202328
  • Julia commits:
    • Target: 147bdf
    • Baseline: 147bdf
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["display"] 0.01 (5%) ✅ 0.01 (1%) ✅
["plot"] 0.80 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Target

Julia Version 1.9.1
Commit 147bdf428cd (2023-06-07 08:27 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.2 LTS
  uname: Linux 5.15.0-1038-azure #45-Ubuntu SMP Mon Apr 24 15:40:42 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       2687 s          1 s        280 s       2807 s          0 s
       #2  2593 MHz       2197 s          2 s        244 s       3258 s          0 s
  Memory: 6.7812042236328125 GB (5238.171875 MB free)
  Uptime: 585.52 sec
  Load Avg:  1.04  1.07  0.57
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
  Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.9.1
Commit 147bdf428cd (2023-06-07 08:27 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.2 LTS
  uname: Linux 5.15.0-1038-azure #45-Ubuntu SMP Mon Apr 24 15:40:42 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       3924 s          1 s        305 s       2898 s          0 s
       #2  2593 MHz       2290 s          2 s        254 s       4504 s          0 s
  Memory: 6.7812042236328125 GB (5236.1328125 MB free)
  Uptime: 720.94 sec
  Load Avg:  1.18  1.1  0.66
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
  Threads: 1 on 2 virtual cores

Target result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

  • Time of benchmark: 9 Jun 2023 - 14:1
  • Package commit: add9b8
  • Julia commit: 147bdf
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["display"] 3.216 ms (5%) 360.50 KiB (1%) 6973
["load"] 3.433 s (5%) 4.59 KiB (1%) 92
["load_plot_display"] 3.949 s (5%) 4.62 KiB (1%) 92
["plot"] 700.309 μs (5%) 86.44 KiB (1%) 3123

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.9.1
Commit 147bdf428cd (2023-06-07 08:27 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.2 LTS
  uname: Linux 5.15.0-1038-azure #45-Ubuntu SMP Mon Apr 24 15:40:42 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       2687 s          1 s        280 s       2807 s          0 s
       #2  2593 MHz       2197 s          2 s        244 s       3258 s          0 s
  Memory: 6.7812042236328125 GB (5238.171875 MB free)
  Uptime: 585.52 sec
  Load Avg:  1.04  1.07  0.57
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
  Threads: 1 on 2 virtual cores

Baseline result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

  • Time of benchmark: 9 Jun 2023 - 14:4
  • Package commit: 202328
  • Julia commit: 147bdf
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["display"] 598.063 ms (5%) 15.831 ms 32.85 MiB (1%) 559359
["load"] 3.417 s (5%) 4.59 KiB (1%) 92
["load_plot_display"] 3.980 s (5%) 4.62 KiB (1%) 92
["plot"] 877.410 μs (5%) 86.44 KiB (1%) 3123

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.9.1
Commit 147bdf428cd (2023-06-07 08:27 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.2 LTS
  uname: Linux 5.15.0-1038-azure #45-Ubuntu SMP Mon Apr 24 15:40:42 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       3924 s          1 s        305 s       2898 s          0 s
       #2  2593 MHz       2290 s          2 s        254 s       4504 s          0 s
  Memory: 6.7812042236328125 GB (5236.1328125 MB free)
  Uptime: 720.94 sec
  Load Avg:  1.18  1.1  0.66
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
  Threads: 1 on 2 virtual cores

Runtime information

Runtime Info
BLAS #threads 1
BLAS.vendor() lbt
Sys.CPU_THREADS 2

lscpu output:

Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Address sizes:                   46 bits physical, 48 bits virtual
Byte Order:                      Little Endian
CPU(s):                          2
On-line CPU(s) list:             0,1
Vendor ID:                       GenuineIntel
Model name:                      Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
CPU family:                      6
Model:                           85
Thread(s) per core:              1
Core(s) per socket:              2
Socket(s):                       1
Stepping:                        7
BogoMIPS:                        5187.81
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear
Hypervisor vendor:               Microsoft
Virtualization type:             full
L1d cache:                       64 KiB (2 instances)
L1i cache:                       64 KiB (2 instances)
L2 cache:                        2 MiB (2 instances)
L3 cache:                        35.8 MiB (1 instance)
NUMA node(s):                    1
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     KVM: Mitigation: VMX unsupported
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Mmio stale data:   Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed:          Vulnerable
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Mitigation; Clear CPU buffers; SMT Host state unknown
Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Vendor :Intel
Architecture :Skylake
Model Family: 0x06, Model: 0x55, Stepping: 0x07, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 1024, 36608) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@giordano
Copy link
Contributor

giordano commented Jun 9, 2023

julia> x = y = collect(-10:0.01f0:10);

julia> heatmap(x, y, hypot.(x', y) .+ 1; colorbar_scale=:log10) # => it works

julia> heatmap(x, y, hypot.(x', y); colorbar_scale=:log10) # => clear error message

julia> x = y = collect(-10:0.01:10);

julia> heatmap(x, y, hypot.(x', y) .+ 1; colorbar_scale=:log10) # => it works

julia> heatmap(x, y, hypot.(x', y); colorbar_scale=:log10) # => clear error message

Now the two eltypes are consistent and one gets clear error messages when the color range would be non-finite, instead of getting a confusing blank plot. Thanks! 🚀

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.03 ⚠️

Comparison is base (2023288) 90.31% compared to head (d7a154a) 90.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4770      +/-   ##
==========================================
- Coverage   90.31%   90.29%   -0.03%     
==========================================
  Files          40       40              
  Lines        8744     8746       +2     
==========================================
  Hits         7897     7897              
- Misses        847      849       +2     
Impacted Files Coverage Δ
src/backends/gr.jl 90.31% <25.00%> (-0.16%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeastyBlacksmith BeastyBlacksmith merged commit 1996def into master Jun 9, 2023
@BeastyBlacksmith BeastyBlacksmith deleted the bbs/log-heatmap branch June 9, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] UndefVarError: z_log not defined
2 participants