This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Plots at some point there was a switch in how representing how segments were handled going from:
To:
In Intervals, recipes are used to plot the segments for each Interval. So these segments look like:
I have an MR that updated that, however I've found that it was not working when using such DateTime types. I believe the issue is here. I'm not too sure on the internals of the package, but I believe that we need to add these methods, and top of these original recipes:
This MR simply adds these. Testing with my branch in Intervals, this does create the correct plots. It is unclear whether additional tests are needed, as it looks like this uses a test suite from Plots.
Related:
invenia/Intervals.jl#159
EDIT: Closing this. I've misunderstood the workings of the package here.