reduce method invalidations and latency by remove method of converting PyObject to nothing #1055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to solve the high latency when
using PyCall
in second time like #1052.We found the method defination
Base.convert(::Type{Nothing}, ::MyType)
would create many method invalidations, which casues this latency (see JuliaLang/julia#51389), so this PR remove the methodconvert(::Type{Nothing}, ::PyObject)
, and some patches by @thautwarm solve the auto convertingconvert(::Type{PyAny}, o::PyObject)
.before this PR:
after this PR:
This latency time is estimated in Julia1.9.3 and win10 OS