Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 0.6 abstract type declaration depwarn #359

Merged
merged 1 commit into from
Feb 13, 2017
Merged

Conversation

yuyichao
Copy link
Collaborator

@yuyichao yuyichao commented Feb 11, 2017

DO NOT MERGE NOW!!!!

This requires JuliaLang/Compat.jl#325 and a new tag. I'm using this (and other) PR's to check if the implementation is correct.

Ready now.

@yuyichao
Copy link
Collaborator Author

Compat tagged, CI reenabled.

@codecov-io
Copy link

codecov-io commented Feb 13, 2017

Codecov Report

Merging #359 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   63.92%   63.92%           
=======================================
  Files          15       15           
  Lines        1400     1400           
=======================================
  Hits          895      895           
  Misses        505      505
Impacted Files Coverage Δ
src/conversions.jl 67.62% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58d30ed...59beada. Read the comment docs.

@stevengj stevengj merged commit 479c828 into JuliaPy:master Feb 13, 2017
@yuyichao yuyichao deleted the 0.6 branch February 13, 2017 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants