Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QUBOTools -> v0.9; QUBODrivers -> 0.3 #8

Merged
merged 10 commits into from
Sep 24, 2023
Merged

Conversation

pedromxavier
Copy link
Member

@pedromxavier pedromxavier commented Sep 24, 2023

This PR comes with a considerable rewrite of the interface and the @setup system, as an effort to keep up with new requirements and the updates implemented down at QUBOTools.jl.

Summary

  • In @setup, values can now be expressions, allowing for lazy evaluation. This solves a problem that appeared when using default values from Python modules (via PythonCall), where pointers to imports were not assigned yet during compile time, leading to segfault.
  • Features as Spin <: MOI.AbstractScalarSet variables, parsing MOI.ModelLike into QUBOTools.Model and MOI.VariableIndex dispatch for PBO.varlt are now provided by QUBOTools.jl's extension for MathOptInterface.jl.
  • Sense & domain are not in @setup anymore. They are now managed during QUBOTools.qubo|ising calls and at the moment in which the QUBOTools.SampleSet is returned. This makes the overall pipeline more flexible and takes part of the burden away from the frame casting system.

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch coverage: 76.04% and project coverage change: +12.15% 🎉

Comparison is base (2668eaf) 70.01% compared to head (08e226a) 82.17%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master       #8       +/-   ##
===========================================
+ Coverage   70.01%   82.17%   +12.15%     
===========================================
  Files          17       19        +2     
  Lines         697      488      -209     
===========================================
- Hits          488      401       -87     
+ Misses        209       87      -122     
Files Changed Coverage Δ
src/QUBODrivers.jl 100.00% <ø> (ø)
src/library/benchmark/benchmark.jl 0.00% <0.00%> (ø)
src/library/test/examples/corner.jl 100.00% <ø> (ø)
src/library/test/examples/examples.jl 100.00% <ø> (ø)
src/library/test/interface/moi.jl 90.90% <ø> (ø)
src/library/sampler/wrappers/moi.jl 45.07% <45.07%> (ø)
src/library/setup/error.jl 50.00% <50.00%> (ø)
src/interface/attributes.jl 75.00% <75.00%> (ø)
src/interface/sampler.jl 81.25% <81.25%> (ø)
src/library/setup/parse.jl 83.33% <83.33%> (ø)
... and 9 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedromxavier pedromxavier changed the title Update QUBOTools -> v0.9 Update QUBOTools -> v0.9; QUBODrivers -> 0.3 Sep 24, 2023
@pedromxavier pedromxavier added the enhancement New feature or request label Sep 24, 2023
@pedromxavier pedromxavier merged commit f517c0f into master Sep 24, 2023
6 checks passed
@pedromxavier pedromxavier deleted the px/qubotools-v1 branch September 19, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant