Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package naming guidelines link in CONTRIBUTING.md #101935

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

LilithHafner
Copy link
Member

The new link is unstable, but at least it's not broken.

The new link is unstable, but at least it's not broken.
@DilumAluthge
Copy link
Member

@ericphanson @LilithHafner Can we add a linkcheck CI job or something? Maybe just as a cron job that runs once a week and makes sure that no links (in our Markdown files) are dead?

@LilithHafner
Copy link
Member Author

I don't have the bandwidth RN, but I started making a little link checker a bit ago and got as far as https://github.com/LilithHafner/ExtractLinks.jl. My goal was to support broken fragments, something that most link checkers don't have. Any reasonable link checker should be able to spot this kind of breakage, though.

@LilithHafner
Copy link
Member Author

Bump

@fredrikekre
Copy link
Member

I think these docs are on their way back to Pkg. Why not link to the v1.10 Pkg docs here instead of dev?

@LilithHafner
Copy link
Member Author

I think these docs are on their way back to Pkg.

Do you have a link for that PR/issue/plan?

Copy link
Contributor

github-actions bot commented Apr 1, 2024

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label Apr 1, 2024
@DilumAluthge
Copy link
Member

Maybe @fredrikekre was referring to this part of the pkgdocs? https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines

@DilumAluthge DilumAluthge merged commit f9707ac into JuliaRegistries:master Apr 1, 2024
10 checks passed
@LilithHafner LilithHafner deleted the patch-2 branch April 1, 2024 20:36
@fredrikekre
Copy link
Member

I was referring to JuliaLang/Pkg.jl#3818 and JuliaLang/julia#53509.

@LilithHafner
Copy link
Member Author

Ah, thank you. I was not aware of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants