Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: StatsBase v0.31.0 #1762

Merged
merged 1 commit into from
Jul 4, 2019
Merged

New version: StatsBase v0.31.0 #1762

merged 1 commit into from
Jul 4, 2019

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator
New version: StatsBase v0.31.0
3d2df3f 
UUID: 2913bbd-ae8a-5f71-8c99-4fb6c76f3a91
Repo: https://github.com/JuliaStats/StatsBase.jl.git
Tree: 2b6ca97be7ddfad5d9f16a13fe277d29f3d11c23

Registrator tree SHA: 3358484330f361397979cc5f65a9354333511e25
JuliaRegistrator referenced this pull request in JuliaStats/StatsBase.jl Jul 3, 2019
@rofinn @ararslan
Bump minor version number (#502)
e2ceeec 
Since `eweights` is now being exported we should bump the minor version number
@fredrikekre
Copy link
Member

0.30.1? Or is this truly breaking this time?

@rofinn
Copy link
Contributor

rofinn commented Jul 4, 2019

This is breaking because it changes the package exports and may introduce collisions as discussed here:

@nickrobinson251
Copy link
Contributor

nickrobinson251 commented Jul 4, 2019 •
edited
Loading

It adds a feature, that adds an export: eweights. Adding an export was decided to be breaking (though this conversation happened mostly offline; for reference JuliaStats/StatsBase.jl#501).

ping @ararslan @rofinn

@rofinn
Copy link
Contributor

rofinn commented Jul 4, 2019

We've also talked about this in the julia slack in general. The preference seems to be that new exports should not be point releases, but shouldn't require a major release on post-1.0 packages. The ideal is that StatsBase will hit 1.0 sooner rather than later.

@fredrikekre fredrikekre merged commit c5848ef into master Jul 4, 2019
@julia-tagbot
Copy link

julia-tagbot bot commented Jul 4, 2019

I tried to create a release but ran into this error:

App is installed for user but the repository is not enabled

To retry, comment on this PR with the phrase TagBot tag.
cc: @christopher-dG

@delete-merged-branch delete-merged-branch bot deleted the register/StatsBase/v0.31.0 branch July 4, 2019 17:00
@ararslan
Copy link
Member

ararslan commented Jul 4, 2019

TagBot tag

@julia-tagbot
Copy link

julia-tagbot bot commented Jul 4, 2019

I tried to create a release but ran into this error:

App is installed for user but the repository is not enabled

To retry, comment on this PR with the phrase TagBot tag.
cc: @christopher-dG

@ararslan
Copy link
Member

ararslan commented Jul 4, 2019

Oh, for some reason TagBot was only enabled for a few repos.

TagBot tag

@ararslan
Copy link
Member

ararslan commented Jul 4, 2019

TagBot tag

@rofinn
Copy link
Contributor

rofinn commented Jul 4, 2019

@ararslan I already just manually made the tag

@ararslan
Copy link
Member

ararslan commented Jul 4, 2019

Oh, okay. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JuliaRegistrator @fredrikekre @rofinn @nickrobinson251 @ararslan