New version: ChainRules v0.7.37 #26142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JuliaRegistrator
commented
Dec 9, 2020
JuliaRegistrator
commented
- Registering package: ChainRules
- Repository: https://github.com/JuliaDiff/ChainRules.jl
- Created by: @willtebbutt
- Version: v0.7.37
- Commit: 80443b1c6e3bc1b2d7462f89388b10ffb3fb5a8d
- Reviewed by: @willtebbutt
- Reference: JuliaDiff/ChainRules.jl@80443b1#commitcomment-44970672
UUID: 082447d4-558c-5d27-93f4-14fc19e9eca2 Repo: https://github.com/JuliaDiff/ChainRules.jl.git Tree: 78c2fa84cf13ce7d821f23947f66212c1f504960 Registrator tree SHA: e934b8c55381f28735124f23e8f7e96d09b20416
JuliaRegistrator
referenced
this pull request
in JuliaDiff/ChainRules.jl
Dec 9, 2020
* Revamp Cholesky implementation * Bump patch * Tidy up + fix syntax * Reinstate tests * Update src/rulesets/LinearAlgebra/factorization.jl Co-authored-by: Seth Axen <seth.axen@gmail.com> * Update src/rulesets/LinearAlgebra/factorization.jl Co-authored-by: Seth Axen <seth.axen@gmail.com> * Conjugate trsm! Co-authored-by: Seth Axen <seth.axen@gmail.com> * Rename to DeltaC and use BlasFloat * Conjugate in both places * Change diag scaling for Complex Co-authored-by: Seth Axen <seth.axen@gmail.com> * Fix naming * Use HermOrSym and generalise Diagonal chol to complex * Revert to Real * Fix naming * Test cholesky(::Real) * Tidy up Diagonal cholesky * Restrict to BlasReal * Refactor Diagonal pullback slightly * Reinstate all tests * Update src/rulesets/LinearAlgebra/factorization.jl Co-authored-by: Seth Axen <seth.axen@gmail.com> * Fix up broken tests * Address code review queries Co-authored-by: Seth Axen <seth.axen@gmail.com>
|
Your If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.