Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: RegistryCI v7.7.0 #66305

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 0c95cc5-2f7e-43fe-82dd-79dbcba86b32
Repo: https://github.com/JuliaRegistries/RegistryCI.jl.git
Tree: f5b798cd1ab9a241987d42be57aa560e3518706d

Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec
JuliaRegistrator referenced this pull request in JuliaRegistries/RegistryCI.jl Aug 15, 2022
440: Revise the commit regex. r=ericphanson a=GunnarFarneback

This revises the commit regex to match
```
r"Commit: ([0-9a-f]+)"
```
but no longer requires that it is a markdown item on a line of its own.

The rationale is GunnarFarneback/LocalRegistry.jl#49, which makes use of "git push options" to create a pull request (only effective on GitLab). This provides a very low complexity pull request creation mechanism but has the limitation that it cannot pass newlines.

In terms of robustness and input sanitation this change makes no difference to Registrator generated pull requests.In fact it's rather stricter since the code in total only allows the commit hash to be exactly 40 hexadecimal digits.

Co-authored-by: Gunnar Farnebäck <gunnar.farneback@inify.com>
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch August 15, 2022 23:16 Inactive
@github-actions
Copy link
Contributor

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@JuliaTagBot JuliaTagBot merged commit c8445e5 into master Aug 15, 2022
@JuliaTagBot JuliaTagBot deleted the registrator/registryci/0c95cc5f/v7.7.0 branch August 15, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants