Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: HerbCore v0.1.0 #86573

Merged
merged 1 commit into from
Jul 6, 2023
Merged

New package: HerbCore v0.1.0 #86573

merged 1 commit into from
Jul 6, 2023

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator
New package: HerbCore v0.1.0
28e6df0 
UUID: 2b23ba43-8213-43cb-b5ea-38c12b45bd45
Repo: https://github.com/Herb-AI/HerbCore.jl.git
Tree: 199b929b581e179224217a2e46a55ef2b1957b7e

Registrator tree SHA: f73a20c99934db92a256057d0d83ba394036a701
JuliaRegistrator referenced this pull request in Herb-AI/HerbCore.jl Jun 30, 2023
@nicolaefilat
Merge pull request #3 from Herb-AI/package
a76073e 
Added package
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch June 30, 2023 11:56 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • Package name similar to 1 existing package.
    1. Similar to MeshCore. Normalized visual distance 2.40 is at or below cutoff of 2.50.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the Julia Slack to ask for help. Include a link to this pull request.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@nicolaefilat
Copy link

nicolaefilat commented Jun 30, 2023 •
edited
Loading

Hi julia team. I fail the AutoMerge because of a similarity check between HerbCore and MeshCore. The two packages names are quite different.
[noblock]

@giordano giordano merged commit 84f17f2 into master Jul 6, 2023
19 of 20 checks passed
@giordano giordano deleted the registrator-herbcore-2b23ba43-v0.1.0-4a2029218f branch July 6, 2023 16:25
@JuliaTagBot JuliaTagBot mentioned this pull request Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs to be manually merged in 3 days new package Override AutoMerge: name similarity is okay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuliaRegistrator @nicolaefilat @giordano