Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore the "repo URL ends in .jl" AutoMerge check for non-subdirectory packages #267

Closed
DilumAluthge opened this issue Aug 28, 2020 · 5 comments · Fixed by #353
Closed

Restore the "repo URL ends in .jl" AutoMerge check for non-subdirectory packages #267

DilumAluthge opened this issue Aug 28, 2020 · 5 comments · Fixed by #353

Comments

@DilumAluthge
Copy link
Member

We should restore this AutoMerge check for packages that are not in a subdirectory.

I'm not 100% sure how this would be implemented in AutoMerge. @fredrikekre any ideas?
@DilumAluthge DilumAluthge pinned this issue Sep 4, 2020
@ericphanson
Copy link
Member

Dup of #244?

@DilumAluthge
Copy link
Member Author

Yep.

@DilumAluthge
Copy link
Member Author

Any chance you want to take a crack at this? :)

@DilumAluthge DilumAluthge unpinned this issue Oct 12, 2020
@ericphanson
Copy link
Member

Not for a few weeks at least, I'm moving to Spain this weekend!

@DilumAluthge
Copy link
Member Author

Good luck with the move!

@DilumAluthge DilumAluthge mentioned this issue Mar 12, 2021
Merged
bors bot added a commit that referenced this issue Mar 12, 2021
@bors @DilumAluthge
Merge #353
af4bf8c 
353: If the package is in a subdirectory, check that the repo URL ends in `/PackageName.jl.git` r=DilumAluthge a=DilumAluthge

Fixes #244 
Fixes #267 

This restores the "repo URL ends in /PackageName.jl.git" check.

We only run this check if the package is not a subdirectory package.

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@DilumAluthge @ericphanson