Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TagBot: Handle repos where issues are disabled #305

Merged
merged 4 commits into from
Dec 8, 2020
Merged

TagBot: Handle repos where issues are disabled #305

merged 4 commits into from
Dec 8, 2020

Conversation

christopher-dG
Copy link
Member

Closes #304

@christopher-dG christopher-dG changed the title Handle repos where issues are disabled TagBot: Handle repos where issues are disabled Dec 1, 2020
@christopher-dG
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Dec 1, 2020
@bors
Try #305:
a44ebe9
@DilumAluthge
Copy link
Member

If this happens, maybe TagBot should post a comment on the general registry pr? Where the contents of the comment are something like "warning, issues are disabled on the repo"?

@DilumAluthge
Copy link
Member

IDK, that's probably too much work.

@christopher-dG
Copy link
Member Author

Maybe in the future, but for now this is so rare that it doesn't really matter.

@codecov
Copy link

codecov bot commented Dec 1, 2020 •
edited
Loading

Codecov Report

Merging #305 (6690f3c) into master (844013d) will decrease coverage by 0.29%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
- Coverage   83.43%   83.13%   -0.30%     
==========================================
  Files          24       24              
  Lines        1274     1281       +7     
==========================================
+ Hits         1063     1065       +2     
- Misses        211      216       +5
Impacted Files Coverage Δ
src/TagBot/TagBot.jl 69.23% <37.50%> (-4.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 844013d...6690f3c. Read the comment docs.

@bors
Copy link
Contributor

bors bot commented Dec 2, 2020

try

Build failed:

  • continuous-integration/travis-ci/push

@christopher-dG
Copy link
Member Author

oops, i'll fix the test tomorrow

@christopher-dG
Copy link
Member Author

bors merge

bors bot added a commit that referenced this pull request Dec 3, 2020
@bors @christopher-dG
Merge #305
f779ffd 
305: TagBot: Handle repos where issues are disabled r=christopher-dG a=christopher-dG

Closes #304

Co-authored-by: Chris de Graaf <me@cdg.dev>
@bors
Copy link
Contributor

bors bot commented Dec 3, 2020

Build failed:

  • continuous-integration/travis-ci/push

@christopher-dG
Copy link
Member Author

Oh, the error isn't mine anymore, it's the deprecation in HTTP 🤷 We should get an HTTP release soon so might as well just wait until then and bump HTTP compat.

@christopher-dG
Copy link
Member Author

bors try

I think this ought to work now that HTTP 0.9.1 is here

bors bot added a commit that referenced this pull request Dec 7, 2020
@bors
Try #305:
5751415
@christopher-dG
Copy link
Member Author

bors merge

bors bot added a commit that referenced this pull request Dec 7, 2020
@bors @christopher-dG
Merge #305
6d4bba9 
305: TagBot: Handle repos where issues are disabled r=christopher-dG a=christopher-dG

Closes #304

Co-authored-by: Chris de Graaf <me@cdg.dev>
@bors
Copy link
Contributor

bors bot commented Dec 7, 2020

try

Build failed:

@christopher-dG
Copy link
Member Author

Oh... we're still getting the deprecation warning. That seems wrong.

@bors
Copy link
Contributor

bors bot commented Dec 8, 2020

Timed out.

@christopher-dG
Copy link
Member Author

bors merge

PLEASE

bors bot added a commit that referenced this pull request Dec 8, 2020
@bors @christopher-dG
Merge #305
a9102ae 
305: TagBot: Handle repos where issues are disabled r=christopher-dG a=christopher-dG

Closes #304

Co-authored-by: Chris de Graaf <me@cdg.dev>
@bors
Copy link
Contributor

bors bot commented Dec 8, 2020

Build failed:

  • continuous-integration/travis-ci/push

@christopher-dG
Copy link
Member Author

bors merge ?

@bors
Copy link
Contributor

bors bot commented Dec 8, 2020

Build succeeded:

@bors bors bot merged commit 043f2bf into master Dec 8, 2020
@bors bors bot deleted the cdg/disabled-issues branch December 8, 2020 19:07
@christopher-dG
Copy link
Member Author

BLESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TagBot: handle repos with issues disabled
2 participants
@christopher-dG @DilumAluthge