Pass HOME to subprocesses #306
Conversation
|
bors try |
christopher-dG
force-pushed
the
cdg/envs
branch
from
ee6da62
to
f79835e
Compare
|
bors try |
tryAlready running a review |
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
==========================================
+ Coverage 83.13% 83.26% +0.12%
==========================================
Files 24 24
Lines 1281 1273 -8
==========================================
- Hits 1065 1060 -5
+ Misses 216 213 -3
Continue to review full report at Codecov.
|
tryTimed out. |
|
I've been seeing SimpleMock hanging on nightly for another package, perhaps same thing here. |
If you want, you can add a |
|
Yeah I'll probably do something like that. I'll get these PRs figured out tomorrow. |
christopher-dG
force-pushed
the
cdg/envs
branch
from
f79835e
to
9b2d59a
Compare
|
bors merge PLEASE I AM BEGGING YOU |
306: Pass HOME to subprocesses r=christopher-dG a=christopher-dG Closes #245 Lots of stuff needs HOME to work properly. More concretely, both Git CLI and LibGit2 get their config from `$HOME/.gitconfig` by default, and that breaks when it's unset. Co-authored-by: Chris de Graaf <me@cdg.dev>
|
Build failed: |
|
@DilumAluthge is there no way for me to not bump the version? (the current version is not released) |
|
Yeah, comment out the "VersionVigilante" line in the |
|
bors merge |
306: Pass HOME to subprocesses r=christopher-dG a=christopher-dG Closes #245 Lots of stuff needs HOME to work properly. More concretely, both Git CLI and LibGit2 get their config from `$HOME/.gitconfig` by default, and that breaks when it's unset. Co-authored-by: Chris de Graaf <me@cdg.dev>
|
I am confused as to why this isn't merged now. |
|
Can you go to settings and uncheck VersionVigilante as a required status check? |
|
I don't see any setting for that, unfortunately. |
|
(Settings -> branch protection -> master) Anyway should be good now. bors merge |
|
Oh, I thought you mean in bors settings 🤦 |
|
Build succeeded:
|
Closes #245
Lots of stuff needs HOME to work properly.
More concretely, both Git CLI and LibGit2 get their config from
$HOME/.gitconfigby default, and that breaks when it's unset.