More fixes for the pkgdir_from_depot and meets_version_has_osi_license functions

[DilumAluthge]

No description provided.

[DilumAluthge]

Example failure: JuliaRegistries/General#31739

[DilumAluthge]

bors merge

[bors]

Build succeeded:

• Integration/Julia ^1.6.0-0/ubuntu-latest/x64
• Unit/Julia 1.3/ubuntu-latest/x64
• Unit/Julia 1.4/ubuntu-latest/x64
• Unit/Julia 1.5/ubuntu-latest/x64
• Unit/Julia ^1.6.0-0/ubuntu-latest/x64
• Unit/Julia 1/ubuntu-latest/x64
• Unit/Julia nightly/ubuntu-latest/x64
• VersionVigilante

[ericphanson]

Thanks a lot for the fixes @DilumAluthge. Any ideas why Pkg.add is installing more than one version of the package? E.g. in https://github.com/JuliaRegistries/General/runs/2094093271?check_suite_focus=true it has two,

┌ Info: 
     Copying registry from `~/work/General/General`
│   pkgdir_parent = "/tmp/jl_TjpUOK/packages/NMFk"
│   all_pkgdir_elements =
│    2-element Vector{String}:
│     "t59Nq"
└     "vJgC8"

[DilumAluthge]

I have no idea. That is very strange....