Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoMerge: Respect the Override AutoMerge: name similarity is okay label #536

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

ericphanson
Copy link
Member

...by turning off the distance check whenever the label is applied. The github action should be updated to activate when labels are added, for best effect, as shown in the example yaml.

@ericphanson
Copy link
Member Author

bump @DilumAluthge

@DilumAluthge
Copy link
Member

Should we just rename our label (on the General repo) and remove the colon character?

@ericphanson
Copy link
Member Author

I think it's fine, it's nice to not have 2 labels or have to delete the old ones, and it just needs an extra quote

@ericphanson
Copy link
Member Author

Bump- would be nice if folks with triage access could help here!

Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not thrilled by the fact that we now have to run AutoMerge when labels are added or removed. But, off the top of my head, I can't think of an alternate approach.

And I do think that having this functionality will reduce the amount of time that human registry committers will need to spend. So, let's give this a try.

I've made a few comments, and once those are addressed, I think this is good to go.

example_github_workflow_files/automerge.yml Outdated Show resolved Hide resolved
example_github_workflow_files/automerge.yml Outdated Show resolved Hide resolved
@ericphanson
Copy link
Member Author

I'm not thrilled by the fact that we now have to run AutoMerge when labels are added or removed. But, off the top of my head, I can't think of an alternate approach.

We only run when some specific labels are added or removed, not any labels!

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a try.

@DilumAluthge DilumAluthge changed the title Respect the Override AutoMerge: name similarity is okay label AutoMerge: Respect the Override AutoMerge: name similarity is okay label Jan 29, 2024
@ericphanson ericphanson added this pull request to the merge queue Jan 29, 2024
Merged via the queue into master with commit 2a13ff8 Jan 29, 2024
11 checks passed
@ericphanson ericphanson deleted the eph/respect-labels branch January 29, 2024 13:29
ericphanson referenced this pull request Jan 30, 2024
* Upgrade to Documenter v1

* Update make.jl

* Update Project.toml

---------

Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
ericphanson added a commit to JuliaRegistries/General that referenced this pull request Jan 30, 2024
To be merged once JuliaRegistries/RegistryCI.jl#536 is operational on General

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants