Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow LazyJLLWrappers for JLLs #571

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow LazyJLLWrappers for JLLs #571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/AutoMerge/jll.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,17 @@ const guideline_allowed_jll_nonrecursive_dependencies = Guideline(;
function meets_allowed_jll_nonrecursive_dependencies(
working_directory::AbstractString, pkg, version
)
# If you are a JLL package, you are only allowed to have five kinds of dependencies:
# If you are a JLL package, you are only allowed to have the following dependencies:
# 1. Pkg
# 2. Libdl
# 3. Artifacts
# 4. JLLWrappers
# 4. JLLWrappers (or LazyJLLWrappers)
# 5. LazyArtifacts
# 6. TOML
# 8. MPIPreferences
# 7. other JLL packages
# 7. MPIPreferences
# 8. other JLL packages
all_dependencies = _get_all_dependencies_nonrecursive(working_directory, pkg, version)
allowed_dependencies = ("Pkg", "Libdl", "Artifacts", "JLLWrappers", "LazyArtifacts", "TOML", "MPIPreferences")
allowed_dependencies = ("Pkg", "Libdl", "Artifacts", "JLLWrappers", "LazyJLLWrappers", "LazyArtifacts", "TOML", "MPIPreferences")
for dep in all_dependencies
if dep ∉ allowed_dependencies && !is_jll_name(dep)
return false,
Expand Down
Loading