WIP: faciliate local testing #853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@filchristou Don't include DistributedRL for the moment? Not sure that it has been migrated to the latest syntax, etc. I would only include the sub-packages used in demoed, here (https://github.com/JuliaReinforcementLearning/ReinforcementLearning.jl/blob/main/src/devmode.jl) |
|
Closing this for now, feel free to reopen. |
|
Hi. Sorry for the delay. I believe I will find the time before juliacon to seriously engage with this. |
|
Some related questions here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An early draft of what I meant in #843 (comment)
At the moment doing
$> julia --project ./testand thenjulia> include(./test/runtests.jl)will succesfully test ReinforcementLearningCore and ReinforcementLearningBase.I had some problems with ReinforcementLearningEnvironments, but I think with time I could (probably) get it to work.
I think this approach might be interesting. I will be investigating it further, but firstly I would like to share the idea in case it's a no-go for you, so that nobody wastes time.
I had some problems with
deving DistributedReinforcementLearning and ReinforcementLearningExperiments.. still not sure why.It's rather scary seeing all these dependencies together.
So please, although it's non breaking and harmless, don't merge still!