Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize SAP serialization (& stashing), testing, and SDK integration #851

Merged
merged 10 commits into from
Apr 20, 2022
Merged

Standardize SAP serialization (& stashing), testing, and SDK integration #851

merged 10 commits into from
Apr 20, 2022

Conversation

dehann
Copy link
Member

@dehann dehann commented Apr 18, 2022 •
edited
Loading

@dehann dehann self-assigned this Apr 18, 2022
@dehann dehann added this to the v0.0.x milestone Apr 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022 •
edited
Loading

Codecov Report

Merging #851 (f6f91e3) into master (da0db99) will decrease coverage by 2.79%.
The diff coverage is 70.45%.

@@            Coverage Diff             @@
##           master     #851      +/-   ##
==========================================
- Coverage   14.21%   11.42%   -2.80%     
==========================================
  Files          47       46       -1     
  Lines        2716     2732      +16     
==========================================
- Hits          386      312      -74     
- Misses       2330     2420      +90
Impacted Files Coverage Δ
src/Deprecated.jl 0.00% <ø> (ø)
src/zmq/services/ZmqServer.jl 0.00% <ø> (ø)
src/images/ScatterAlignPose2.jl 86.72% <56.66%> (-8.52%) ⬇️
src/UserFunctions.jl 31.11% <100.00%> (+31.11%) ⬆️
src/zmq/ZmqCaesar.jl 0.00% <0.00%> (-100.00%) ⬇️
src/zmq/services/session.jl 0.00% <0.00%> (-66.34%) ⬇️
src/zmq/services/factors/factorSerialization.jl 0.00% <0.00%> (-36.37%) ⬇️
.../zmq/services/factors/distributionSerialization.jl 0.00% <0.00%> (-23.53%) ⬇️
src/zmq/models/session.jl

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@dehann dehann changed the title start experimental SAP entryId serialization SAP stash serialization testing wip Apr 19, 2022
@dehann dehann changed the title SAP stash serialization testing wip Standardize SAP stash serialization, testing, and SDK integration Apr 20, 2022
@dehann dehann changed the title Standardize SAP stash serialization, testing, and SDK integration Standardize SAP serialization (& stashing), testing, and SDK integration Apr 20, 2022
@dehann dehann mentioned this pull request Apr 20, 2022
Closed
@dehann dehann marked this pull request as ready for review April 20, 2022 05:22
@dehann dehann merged commit 1b8826d into master Apr 20, 2022
@dehann
Copy link
Member Author

dehann commented Apr 20, 2022

Should greatly simplify:

@dehann dehann modified the milestones: v0.0.x, v0.13.5 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dehann dehann

Labels
deprecated enhancement maintenance performance serialization testing types
Projects
Code Quality & Improvements
Status: Done
Milestone
v0.13.5
Development

Successfully merging this pull request may close these issues.
2 participants
@dehann @codecov-commenter