enh api on defVariable and typeModName #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehann
added
API
manifolds
VariableType
Codecov Report
@@ Coverage Diff @@
## master #806 +/- ##
==========================================
- Coverage 76.27% 76.21% -0.06%
==========================================
Files 31 31
Lines 2752 2754 +2
==========================================
Hits 2099 2099
- Misses 653 655 +2
Continue to review full report at Codecov.
|
dehann
added a commit
to JuliaRobotics/IncrementalInference.jl
that referenced
this pull request
Oct 15, 2021
Affie
reviewed
Jul 2, 2024
| @@ -102,6 +102,8 @@ macro defVariable(structname, manifold, point_identity) | |||
|
|
|||
| DFG.getPointIdentity(::Type{$structname}) = $point_identity | |||
|
|
|||
| DFG.getVariableType(::typeof($manifold)) = $structname | |||
There was a problem hiding this comment.
@dehann, this is a bug, what was the intention here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.