Optimizing the creation of a CGDFG. #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
===========================================
- Coverage 77.41% 57.87% -19.55%
===========================================
Files 35 35
Lines 3037 3005 -32
===========================================
- Hits 2351 1739 -612
- Misses 686 1266 +580
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hi @GearsAD , assuming this is ready to be merged? |
|
closes #815 |
|
Perhaps not, CI is showing error: [ Info: Testing Driver: CloudGraphsDFG
DFG Structure and Accessors: Test Failed at /home/runner/work/DistributedFactorGraphs.jl/DistributedFactorGraphs.jl/test/testBlocks.jl:175
Expression: getUserData(fg) == Dict(ud)
Evaluated: Dict{Symbol, String}() == Dict(:ud => "udEntry")
Stacktrace:
[1] DFGStructureAndAccessors(::Type{CloudGraphsDFG}, solparams::NoSolverParams)
@ Main ~/work/DistributedFactorGraphs.jl/DistributedFactorGraphs.jl/test/testBlocks.jl:175
[2] DFGStructureAndAccessors(::Type{CloudGraphsDFG})
@ Main ~/work/DistributedFactorGraphs.jl/DistributedFactorGraphs.jl/test/testBlocks.jl:134
[3] macro expansion
@ ~/work/DistributedFactorGraphs.jl/DistributedFactorGraphs.jl/test/interfaceTests.jl:33 [inlined]
[4] macro expansion
@ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
[5] top-level scope
@ ~/work/DistributedFactorGraphs.jl/DistributedFactorGraphs.jl/test/interfaceTests.jl:33
DFG Structure and Accessors: Test Failed at /home/runner/work/DistributedFactorGraphs.jl/DistributedFactorGraphs.jl/test/testBlocks.jl:176
Expression: getRobotData(fg) == Dict(rd)
Evaluated: Dict{Symbol, String}() == Dict(:rd => "rdEntry")
Stacktrace:
[1] DFGStructureAndAccessors(::Type{CloudGraphsDFG}, solparams::NoSolverParams)
@ Main ~/work/DistributedFactorGraphs.jl/DistributedFactorGraphs.jl/test/testBlocks.jl:176
[2] DFGStructureAndAccessors(::Type{CloudGraphsDFG})
@ Main ~/work/DistributedFactorGraphs.jl/DistributedFactorGraphs.jl/test/testBlocks.jl:134
[3] macro expansion
@ ~/work/DistributedFactorGraphs.jl/DistributedFactorGraphs.jl/test/interfaceTests.jl:33 [inlined]
[4] macro expansion
@ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
[5] top-level scope
@ ~/work/DistributedFactorGraphs.jl/DistributedFactorGraphs.jl/test/interfaceTests.jl:33
DFG Structure and Accessors: Test Failed at /home/runner/work/DistributedFactorGraphs.jl/DistributedFactorGraphs.jl/test/testBlocks.jl:177
Expression: getSessionData(fg) == Dict(sd)
Evaluated: Dict{Symbol, String}() == Dict(:sd => "sdEntry")
Stacktrace:
[1] DFGStructureAndAccessors(::Type{CloudGraphsDFG}, solparams::NoSolverParams)
@ Main ~/work/DistributedFactorGraphs.jl/DistributedFactorGraphs.jl/test/testBlocks.jl:177
[2] DFGStructureAndAccessors(::Type{CloudGraphsDFG})
@ Main ~/work/DistributedFactorGraphs.jl/DistributedFactorGraphs.jl/test/testBlocks.jl:134
[3] macro expansion
@ ~/work/DistributedFactorGraphs.jl/DistributedFactorGraphs.jl/test/interfaceTests.jl:33 [inlined]
[4] macro expansion
@ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
[5] top-level scope
@ ~/work/DistributedFactorGraphs.jl/DistributedFactorGraphs.jl/test/interfaceTests.jl:33 |
|
might have basic name conflicts with #845 |
…aphs.jl into 815/cgdfg_createsession
dehann
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User/robot/session is created in a single cal.