Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mergeDataEntries! #906

Merged
merged 3 commits into from
Nov 2, 2022
Merged

add mergeDataEntries! #906

merged 3 commits into from
Nov 2, 2022

Conversation

dehann
Copy link
Member

@dehann dehann commented Oct 31, 2022

No description provided.

@dehann dehann requested a review from Affie October 31, 2022 07:25
@dehann dehann self-assigned this Oct 31, 2022
@dehann dehann added enhancement New feature or request API data: entry=>blob Previously bigdata, suggested over `smalldata` labels Oct 31, 2022
@dehann dehann added this to the v0.18.7 milestone Oct 31, 2022
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #906 (eeab948) into master (5cbec78) will decrease coverage by 0.14%.
The diff coverage is 52.94%.

@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
- Coverage   76.55%   76.41%   -0.15%     
==========================================
  Files          35       35              
  Lines        3011     3027      +16     
==========================================
+ Hits         2305     2313       +8     
- Misses        706      714       +8     
Impacted Files Coverage Δ
src/DistributedFactorGraphs.jl 100.00% <ø> (ø)
src/DataBlobs/services/AbstractDataEntries.jl 67.21% <52.94%> (-6.13%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dehann dehann changed the title add copyDataEntry! add mergeDataEntries! Nov 1, 2022
@Affie
Copy link
Member

Affie commented Nov 1, 2022

I also think merge is the correct thing to do here as apposed to copy.
Just 2 things:

  • I think merge should follow julia: "If the same key is present in another collection, the value for that key will be the value it has in the last collection listed"
  • Please add tests

@dehann dehann merged commit bcf7134 into master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API data: entry=>blob Previously bigdata, suggested over `smalldata` documentation enhancement New feature or request testing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants