Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standarize partials definition and behavior #1492

Open
6 tasks
dehann opened this issue Feb 13, 2022 · 1 comment
Open
6 tasks

Standarize partials definition and behavior #1492

dehann opened this issue Feb 13, 2022 · 1 comment

Comments

@dehann
Copy link
Member

dehann commented Feb 13, 2022

We should do better than define partials as coordinate dimension positions -- i.e.

See legacy workaround: 976a010

@dehann
Copy link
Member Author

dehann commented Dec 29, 2022

Going for partial factors' getManifold to only return the partial manifold definition; as well as getSample to return tangents or points on that partial factor. The rest of the IIF logic should then cater for which variables those factors are connected to and update the numerics accordingly. Currently that is done via factors having .partials::Vector{Int} which strictly specifies the partial dimensions (in coordinates of the variable being updated). This is not perfect and has a bunch of limitations in the near term, but good enough for transition to Manifolds proper so that partial manifolds can be broadly advanced as necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant