Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve types on CCW and CPT #1155

Merged
merged 3 commits into from
Feb 11, 2021
Merged

Improve types on CCW and CPT #1155

merged 3 commits into from
Feb 11, 2021

Conversation

dehann
Copy link
Member

@dehann dehann commented Feb 9, 2021

towards #825

@dehann dehann added this to the v0.21.1 milestone Feb 9, 2021
@dehann dehann marked this pull request as ready for review February 10, 2021 04:14
@codecov-io
Copy link

Codecov Report

Merging #1155 (a1bc487) into master (6ddd346) will decrease coverage by 1.05%.
The diff coverage is 74.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
- Coverage   70.27%   69.21%   -1.06%     
==========================================
  Files          55       55              
  Lines        4282     4281       -1     
==========================================
- Hits         3009     2963      -46     
- Misses       1273     1318      +45     
Impacted Files Coverage Δ
src/FactorGraph.jl 68.48% <ø> (-3.48%) ⬇️
src/IncrementalInference.jl 85.71% <ø> (ø)
src/Deprecated.jl 25.74% <28.57%> (-10.82%) ⬇️
src/ParametricUtils.jl 62.30% <60.27%> (-5.49%) ⬇️
src/ApproxConv.jl 88.88% <93.75%> (+0.26%) ⬆️
src/CalcFactor.jl 77.27% <100.00%> (ø)
src/DeconvUtils.jl 58.13% <100.00%> (ø)
src/FactorGraphTypes.jl 100.00% <100.00%> (ø)
src/Factors/DefaultPrior.jl 46.66% <100.00%> (+11.37%) ⬆️
src/Factors/EuclidDistance.jl 27.27% <100.00%> (-6.07%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a8457...a1bc487. Read the comment docs.

@dehann dehann changed the title minor updates Improve types on CCW and CPT Feb 10, 2021
@dehann dehann self-assigned this Feb 10, 2021
@dehann dehann merged commit 17994bb into master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants