Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only reconstruct gradients if attemptGradients #1688

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

Affie
Copy link
Member

@Affie Affie commented Mar 3, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #1688 (b47a2a8) into master (1851b5d) will increase coverage by 20.89%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1688       +/-   ##
===========================================
+ Coverage   55.50%   76.39%   +20.89%     
===========================================
  Files          74       74               
  Lines        5598     5618       +20     
===========================================
+ Hits         3107     4292     +1185     
+ Misses       2491     1326     -1165     
Impacted Files Coverage Δ
...erialization/services/DispatchPackedConversions.jl 91.66% <ø> (+16.66%) ⬆️
src/entities/CliqueTypes.jl 100.00% <0.00%> (ø)
src/Serialization/entities/AdditionalDensities.jl 100.00% <0.00%> (ø)
...Serialization/entities/SerializingDistributions.jl 100.00% <0.00%> (ø)
src/ParametricUtils.jl 70.07% <0.00%> (+0.52%) ⬆️
src/services/SolveTree.jl 96.38% <0.00%> (+2.40%) ⬆️
src/services/FactorGraph.jl 70.66% <0.00%> (+3.11%) ⬆️
src/services/CalcFactor.jl 78.66% <0.00%> (+3.33%) ⬆️
src/services/BayesNet.jl 65.90% <0.00%> (+5.68%) ⬆️
src/entities/OptionalDensities.jl 8.77% <0.00%> (+6.95%) ⬆️
... and 37 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Affie Affie merged commit 9ba6669 into master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant