Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deconv using CalcFactor dispatch #1789

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Deconv using CalcFactor dispatch #1789

merged 7 commits into from
Oct 24, 2023

Conversation

Affie
Copy link
Member

@Affie Affie commented Oct 17, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1789 (baad03a) into master (4bcc7b4) will decrease coverage by 23.86%.
Report is 17 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head baad03a differs from pull request most recent head a5c2558. Consider uploading reports for the commit a5c2558 to get more accurate results

@@             Coverage Diff             @@
##           master    #1789       +/-   ##
===========================================
- Coverage   76.73%   52.87%   -23.86%     
===========================================
  Files          82       80        -2     
  Lines        5954     5955        +1     
===========================================
- Hits         4569     3149     -1420     
- Misses       1385     2806     +1421     
Files Coverage Δ
src/entities/CalcFactor.jl 58.33% <ø> (ø)
src/services/NumericalCalculations.jl 39.83% <0.00%> (-47.89%) ⬇️
src/services/DeconvUtils.jl 0.00% <0.00%> (-72.31%) ⬇️

... and 49 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Affie Affie added this to the v0.35.0 milestone Oct 20, 2023
@Affie Affie self-assigned this Oct 20, 2023
@Affie Affie marked this pull request as ready for review October 24, 2023 11:44
@Affie Affie merged commit 22dd738 into master Oct 24, 2023
5 checks passed
@Affie Affie deleted the 23Q4/enh/decon_calcfac branch October 24, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants