Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently omit normalization for quaternions. #514

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Conversation

tkoolen
Copy link
Collaborator

@tkoolen tkoolen commented Nov 13, 2018

The main reason for this is to provide better support for scalar types for which square root or division are not defined.

The main reason for this is to provide support for scalar types for
which square root or division are not defined.
@codecov-io
Copy link

codecov-io commented Nov 13, 2018

Codecov Report

Merging #514 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #514   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files          38       38           
  Lines        1700     1700           
=======================================
  Hits         1687     1687           
  Misses         13       13
Impacted Files Coverage Δ
src/joint_types/quaternion_spherical.jl 100% <ø> (ø) ⬆️
src/joint_types/quaternion_floating.jl 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86bc94b...328f710. Read the comment docs.

@tkoolen tkoolen merged commit e68f5a7 into master Nov 13, 2018
@tkoolen tkoolen deleted the tk/no-normalize branch November 13, 2018 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants