Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weird juxtaposition syntax in tests #33

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

c42f
Copy link
Contributor

@c42f c42f commented Jun 6, 2023

Found as part of testing for JuliaLang/julia#46372 - JuliaSyntax.jl rejects this - it's more consistent about disallowing string juxtaposition with all keywords than the reference parser.

@chriselrod chriselrod merged commit 5aeeb3a into JuliaSIMD:master Jun 6, 2023
@chriselrod
Copy link
Member

This doesn't change the library, and tests will still fail for unrelated reeasons.

But would it help the JuliaSyntax testing if I make a new release anyway?

@c42f
Copy link
Contributor Author

c42f commented Jun 6, 2023

Thanks for asking! It would certainly be nice, but it's not critical to have a new release - there's a handfull of other libs in General which have similar issues, several of which seem abandoned by their authors at this point...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants