Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate core #20

Merged
merged 5 commits into from
Mar 20, 2021
Merged

Separate core #20

merged 5 commits into from
Mar 20, 2021

Conversation

chriselrod
Copy link
Member

No description provided.

@DilumAluthge
Copy link
Member

Looks like you need a compat entry for StrideArraysCore.

@chriselrod
Copy link
Member Author

Yeah.
I also fixed the error in log(::VecUnroll{N,1,T,T}) locally.

@DilumAluthge
Copy link
Member

There's also a MethodError: no method matching vnot(::Bool).

@DilumAluthge
Copy link
Member

DilumAluthge commented Mar 20, 2021

Good thing CI is working again 😂

@chriselrod
Copy link
Member Author

chriselrod commented Mar 20, 2021

That was the log error.

It also isn't working again. CI was disabled for JuliaSIMD, not for chriselrod (it never stopped working for packages under my account, just for packages in the JuliaSIMD org).

@DilumAluthge
Copy link
Member

Ohhh I didn't realize this repo was on chriselrod.

@chriselrod
Copy link
Member Author

Maybe I'll transfer it, but definitely not right now lol
Something like JuliaArrays may also make more sense than JuliaSIMD anyway.

@codecov-io
Copy link

codecov-io commented Mar 20, 2021

Codecov Report

Merging #20 (6a04841) into master (0cd290d) will increase coverage by 0.15%.
The diff coverage is 82.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   68.61%   68.76%   +0.15%     
==========================================
  Files          12        8       -4     
  Lines         650      381     -269     
==========================================
- Hits          446      262     -184     
+ Misses        204      119      -85     
Impacted Files Coverage Δ
src/StrideArrays.jl 100.00% <ø> (ø)
src/initialization.jl 93.02% <60.00%> (+22.43%) ⬆️
src/size_and_strides.jl 33.33% <75.00%> (+15.15%) ⬆️
src/broadcast.jl 72.47% <90.90%> (+0.63%) ⬆️
src/type_declarations.jl 87.87% <100.00%> (+7.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6be7e9...6a04841. Read the comment docs.

@chriselrod chriselrod merged commit 3c1c792 into master Mar 20, 2021
@chriselrod chriselrod deleted the separatecore branch May 23, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants