fixed last index

JuliaSparse · Jul 22, 2023 · 4dd4a6a · 4dd4a6a
1 parent 5136cc0
commit 4dd4a6a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/sparsevector.jl b/src/sparsevector.jl
@@ -169,7 +169,7 @@ function _partialview_end_indices(x::SparseVectorPartialView)
         first_idx = findfirst(>=(x.indices[1][begin]), nzinds)
         last_idx = findlast(<=(x.indices[1][end]), nzinds)
         # empty view
-        if first_idx === nothing
+        if first_idx === nothing || last_idx === nothing
             last_idx = length(nzinds)
             first_idx = last_idx+1
         end

diff --git a/test/sparsevector.jl b/test/sparsevector.jl
@@ -788,7 +788,7 @@ spv_x2 = SparseVector(8, [1, 2, 6, 7], [3.25, 4.0, -5.5, -6.0])
         (SparseVector(5, [1], [1.0]), SparseVector(5, [2], [3.0])),
         (SparseVector(5, [3], [2.0]), SparseVector(5, [4], [3.0])),
     ]
-    @testset "View operations $((xa, xb)), op $op" for (xa, xb) in test_vectors, op in (-, +)
+    @testset "View operations $((collect(xa), collect(xb))), op $op" for (xa, xb) in test_vectors, op in (-, +)
         r1 = op(@view(xa[1:end]), @view(xb[1:end]))
         @test r1 == op(xa, xb)
         @test r1 isa SparseVector