-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Int32 indices, switch to SuiteSparse 7 #380
Conversation
Codecov Report
@@ Coverage Diff @@
## main #380 +/- ##
==========================================
- Coverage 93.97% 93.57% -0.40%
==========================================
Files 12 12
Lines 7480 7520 +40
==========================================
+ Hits 7029 7037 +8
- Misses 451 483 +32
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I'm going to have to test this on a 32-bit VM to get anywhere on this |
In case you don't already have one, the easiest thing is to get the ubuntu 32 bit docker image on a linux box. |
doctests need updating: https://buildkite.com/julialang/julia-master/builds/22783#01877398-57ae-43e1-8707-50d39367ca4b Also most of the QR tests are failing on 32-bit, but cholesky seems ok: https://buildkite.com/julialang/julia-master/builds/22783#01877398-50ea-4bc7-aba6-87ce01031f4a |
Okay that's good info, I'm not surprised QR is a bit worse, I made much more cursory changes there. I'll update. Will do doctests too. |
The newest version of SPQR will introduce a small regression for us, we have to convert HPinv from Int32->Int64->Int32 when Ti === Int64. There are no |
Is this breaking for the Julia user, or is it just that we need to adjust SPQR bindings to do some extra conversions so that tests pass? |
Just extra conversions. |
@ViralBShah to unblock progress I've temporarily taken out the SPQR 32-bit plat tests. These should "just work" after the upgrade to SS7.1 when Tim fixes this upstream. I don't see another option rn |
I suppose we should wait for SuiteSparse 7.1. |
No description provided.