Specialize 3-arg dot for sparse self-adjoint matrices
#398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
==========================================
+ Coverage 92.38% 92.41% +0.03%
==========================================
Files 12 12
Lines 7600 7661 +61
==========================================
+ Hits 7021 7080 +59
- Misses 579 581 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Can this be merged? |
|
Should we hold back things until we get the SuiteSparse 7 PR merged, which should be soon, and get CI working reliably again? |
|
Shall we merge now and include in v1.10? |
|
Yes, I think it makes sense to merge for inclusion in 1.10. The tests seem sufficient here and perhaps that is enough to merge (I haven't been able to review the actual code ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83.
I only later realized that this might be resolved by the iternz iterator. But, for the time being, I suggest we fix this by explicit code, and condense later when the nz-iterator becomes available.